Review contrib-slider README

Description

Review accuracy and quality:
https://github.com/chucklorenz/demo-wiki/wiki/slider-RDME
Feedback goes to Chuck.
Reassign to Chuck.
Chuck push to Adapt github wiki.

Activity

Show:
DanG
September 2, 2015, 9:56 AM

Readme is fine. However I'm not sure the following sentence on accessibility is quite right. this is the same for all plugins with ariaRegions defined in course.json.

Should the region's text need to be customised, it can be found within the globals object in properties.schema.

My understanding is that the grunt build/dev task will create ariaRegion properties in _globals. _components or _globals._extensions in course.json if they are not already populated. the grunt task will take these values from the properties.schema. Would the correct process for a framework developer be to alter these values in course.json? If they alter the plugins properties.schema they may be overwritten on adapt install command.

DanG
September 30, 2015, 1:53 PM

I would suggest this change:

Should the region's text need to be customised, it can be found within the globals object in [course.json](https://github.com/adaptlearning/adapt_framework/blob/master/src/course/en/course.json).

Assignee

DanG

Reporter

Chuck Lorenz

Labels

Time tracking

0m

Time remaining

0m

Sprint

None

Priority

Major
Configure