Review contrib-boxMenu README

Description

Review accuracy and quality:
https://github.com/chucklorenz/demo-wiki/wiki/boxMenu-RDME
Feedback goes to Chuck.
Reassign to Chuck.
Chuck push to Adapt github wiki.

Activity

Show:
Matthew Leathes
July 13, 2015, 11:25 AM

could you do this one?

Kirsty Hames
July 16, 2015, 10:40 AM
Edited

It's pretty much up to date just a few bits to add/change...

  • just waiting on a PR to be merged (https://github.com/adaptlearning/adapt-contrib-boxmenu/pull/50) for corrct use of title/displayTitle.

  • might be worth mentioning aria-labels. Both the menu and menu-item have their own editable label set in course.json (menu, menuItem).

  • currently the _classes attribute isn't applied anywhere within boxmenu. It's only applied to the page element of each contentObject (vanilla theme v2). Whether this just needs to be amended within the readMe or we add this functionality into boxmenu?

  • to update screenshot using v2 vanilla.

  • also I don't know if it's worth mentioning but the contentObject displayTitle and body is used for both the menu item and the page header. In v2 vanilla we now have the addition of pageBody so that both menu and page body can be different rather than pulling in the same content (e.g. keeping a brief intro on the menu item but more content on the page).

Chuck Lorenz
July 19, 2015, 8:59 PM
  • PR (#50) has been merged

  • Accessibility section added to address aria labels.

  • Description of "_classes" has been revised to mention it is applied to page objects. I have not raised the issue of whether it should be applied to the boxmenu menu item.

  • Screen shot will indeed be updated with v2 image.

  • pageBody has been added.

Anonymous
December 17, 2015, 3:22 PM

Hi my name is Sandra and I just wanted to drop you a quick note here instead of calling you. I discovered your Review contrib-boxMenu README - Adapt JIRA page and noticed you could have a lot more visitors. I have found that the key to running a popular website is making sure the visitors you are getting are interested in your niche. There is a company that you can get targeted traffic from and they let you try their service for free for 7 days. I managed to get over 300 targeted visitors to day to my website. Visit them here: http://digitalvikn.com.br/u/nk00

Assignee

Chuck Lorenz

Reporter

Chuck Lorenz

Labels

None

Time tracking

0m

Time remaining

0m

Sprint

None

Priority

Major
Configure